From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4 1/2] net/mlx5: link status update separation Date: Mon, 11 Sep 2017 17:12:16 +0100 Message-ID: References: <1504710238-25726-1-git-send-email-matan@mellanox.com> <20170906151414.GY4301@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Nelio Laranjeiro , dev@dpdk.org To: Adrien Mazarguil , Matan Azrad Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 01B81237 for ; Mon, 11 Sep 2017 18:12:21 +0200 (CEST) In-Reply-To: <20170906151414.GY4301@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/6/2017 4:14 PM, Adrien Mazarguil wrote: > On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote: >> Link status is sometimes inconsistent during a LSC event. >> When it occurs, the PMD refrains from immediately notifying >> the application; instead, an alarm is scheduled to check >> link status later and notify the application once it has settled. >> >> In the previous code the alarm callback calls to the interrupt >> handler for link status recheck and may cause to unnecessary >> interrupt events check. >> >> This patch separates the link status update and the interrupt event >> handler to avoid the unnecessary check and arranges the interrupt >> handler for more interrupt supports in the future. >> >> Comment was added in the new function to explain the inconsistent >> link status reason. >> >> Signed-off-by: Matan Azrad > > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.