From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 4/9] virtio: Don't fill dev_info->driver_name Date: Tue, 20 Dec 2016 12:17:05 +0000 Message-ID: References: <1482232315-21626-1-git-send-email-jblunck@infradead.org> <1482232315-21626-5-git-send-email-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: shreyansh.jain@nxp.com, david.marchand@6wind.com, stephen@networkplumber.org To: Jan Blunck , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 19CF3FB56 for ; Tue, 20 Dec 2016 13:17:08 +0100 (CET) In-Reply-To: <1482232315-21626-5-git-send-email-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/20/2016 11:11 AM, Jan Blunck wrote: > This is overwritten in rte_eth_dev_info_get(). > > Signed-off-by: Jan Blunck > Reviewed-by: David Marchand > --- > drivers/net/virtio/virtio_ethdev.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 079fd6c..741688e 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > uint64_t tso_mask; > struct virtio_hw *hw = dev->data->dev_private; > > - if (dev->pci_dev) > - dev_info->driver_name = dev->driver->pci_drv.driver.name; > - else > - dev_info->driver_name = "virtio_user PMD"; > dev_info->max_rx_queues = > RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); > dev_info->max_tx_queues = > This has been already removed in next-net with following commit: 7c6c1857358c ("net: remove dead driver names")