From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 07/12] pdump: disabled by default Date: Tue, 13 Jun 2017 18:15:45 +0100 Message-ID: References: <87a12a85ab782a5995100ea1e2ae80a2c7e0ec5e.1496877060.git.gaetan.rivet@6wind.com> <3AEA2BF9852C6F48A459DA490692831F2A2133A4@irsmsx110.ger.corp.intel.com> <20170611194225.GO29091@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , "Pattan, Reshma" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 036E55583 for ; Tue, 13 Jun 2017 19:15:55 +0200 (CEST) In-Reply-To: <20170611194225.GO29091@bidouze.vm.6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/11/2017 8:42 PM, Gaëtan Rivet wrote: > Hi Reshma, > > On Fri, Jun 09, 2017 at 02:24:58PM +0000, Pattan, Reshma wrote: >> Hi, >> >>> -----Original Message----- >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet >>> Sent: Thursday, June 8, 2017 12:59 AM >>> To: dev@dpdk.org >>> Cc: Gaetan Rivet >>> Subject: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default >>> >>> Signed-off-by: Gaetan Rivet >>> --- >>> config/common_base | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/config/common_base b/config/common_base index >>> cade611..8ec5e4e 100644 >>> --- a/config/common_base >>> +++ b/config/common_base >>> @@ -700,7 +700,7 @@ CONFIG_RTE_KNI_PREEMPT_DEFAULT=y # # Compile >>> the pdump library # -CONFIG_RTE_LIBRTE_PDUMP=y >>> +CONFIG_RTE_LIBRTE_PDUMP=n >>> >>> # >>> # Compile vhost user library >>> -- >>> 2.1.4 >> >> Since, you already mentioned in other mail to Ferruh that config flag disabling patches are only for testers compilation purpose and you have plans to make proper fix by end of June. I will wait on for actual patch. >> > > I said I planned to do so, but found out that I would not have enough > time before the end of June. Sorry about the ambiguous phrasing. > > Do you think you will be able to fix this library in time? KNI uses / depends pci, I am not sure what to fix here. The problem to enable the KNI is build dependency problem, right? I guess problem will be fixes if we can build in following order: - lib/eal - drivers/bus - lib - drivers This was the case when bus drives compiled within eal. What do you think about this build order? > >> Please see if rte_pci.h can be removed from the includes of rte_pdump.c , might be unnecessary include. >> >> Thanks, >> Reshma >