From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vlad Zolotarov <vladz@scylladb.com>
Subject: Re: [PATCH 1/7] ethdev: remove unused flag from header
Date: Fri, 1 Dec 2017 17:30:31 -0500
Message-ID: <e0384702-9c9d-d3ef-7899-cd0e2bdd516c@scylladb.com>
References: <20171201022957.64329-1-ferruh.yigit@intel.com>
 <49eb13f1-e12f-071a-b58b-1cd4852b7c8b@scylladb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, vladz@cloudius-systems.com
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com
 [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id BCFB6324A
 for <dev@dpdk.org>; Fri,  1 Dec 2017 23:30:34 +0100 (CET)
Received: by mail-qk0-f195.google.com with SMTP id b184so15066416qkc.13
 for <dev@dpdk.org>; Fri, 01 Dec 2017 14:30:34 -0800 (PST)
In-Reply-To: <49eb13f1-e12f-071a-b58b-1cd4852b7c8b@scylladb.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

resending after registering with the new email domain ;)
Please, see my comments below.

On 12/01/2017 05:17 PM, Vlad Zolotarov wrote:
>
>
> On 11/30/2017 09:29 PM, Ferruh Yigit wrote:
>> remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header.
>>
>> Flag seems added with the patch that adds LRO support, and intention
>> looks like giving a pointer to application that library supports LRO.
>
> Exactly. Removing this flag may make the existing application "think" 
> that LRO is not supported.
> Why do you want to remove it to begin with?
>
>> Fixes: 8eecb3295aed ("ixgbe: add LRO support")
>> Cc:vladz@cloudius-systems.com
>>
>> Signed-off-by: Ferruh Yigit<ferruh.yigit@intel.com>
>> ---
>>   lib/librte_ether/rte_ethdev.h | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
>> index 341c2d624..e620c3706 100644
>> --- a/lib/librte_ether/rte_ethdev.h
>> +++ b/lib/librte_ether/rte_ethdev.h
>> @@ -172,9 +172,6 @@ extern "C" {
>>   
>>   #include <stdint.h>
>>   
>> -/* Use this macro to check if LRO API is supported */
>> -#define RTE_ETHDEV_HAS_LRO_SUPPORT
>> -
>>   #include <rte_log.h>
>>   #include <rte_interrupts.h>
>>   #include <rte_dev.h>
>