From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/2] eal: fix dynamic logs failing to print
Date: Tue, 21 Nov 2017 10:10:40 -0800
Message-ID: <e0720852-3bf1-a2ad-a3ac-91b59cc9b315@intel.com>
References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com>
 <1772478.GecVQuhyhE@xps> <20171121111416.yffsbci3cswwpzx5@Pavan-LT>
 <5684106.7xpmVRmQS0@xps> <20171121140451.hq4niywykhqgvzbx@Pavan-LT>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>,
 Thomas Monjalon <thomas@monjalon.net>, olivier.matz@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 4840423A
 for <dev@dpdk.org>; Tue, 21 Nov 2017 19:10:41 +0100 (CET)
In-Reply-To: <20171121140451.hq4niywykhqgvzbx@Pavan-LT>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/21/2017 6:04 AM, Pavan Nikhilesh Bhagavatula wrote:
> On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote:
>> 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula:
>>> On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote:
>>>> 20/11/2017 19:40, Ferruh Yigit:
> <snip>
>>>
>>> I will be sending out the patch set soon.
>>
>> These are only the legacy static log types.
>> Are you sure you want to change them?
>> They should be removed when using dynamic logging.
> 
> Actually this same struct is used for registering dynamic logs for legacy
> modules currently,
> 
> /* register legacy log types */
> for (i = 0; i < RTE_DIM(logtype_strings); i++)
> 	__rte_log_register(logtype_strings[i].logtype,
> 		logtype_strings[i].log_id);
> 
> I have just prefixed them with "lib.". If we remove this form here then each
> module has to use constructor style initialisation for logs which would be a
> lot of rework.

That work of each library registering dynamic log themselves needs to be done
somehow but that is bigger task, for this patch just renaming static ones to be
consistent can be enough I think.

Thanks,
ferruh