From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/4] mk: do not build tests by default
Date: Thu, 16 Feb 2017 10:07:56 +0000
Message-ID: <e0a14acc-a6e7-0aaf-414c-01cbee16fb20@intel.com>
References: <20170214151326.7554-1-ferruh.yigit@intel.com>
 <3106919.K5kYvNu2Ff@xps13> <d8920be0-5629-2ee2-fe90-9265fb07b0d6@intel.com>
 <2590637.Rj3BpoAWc4@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Keith Wiles <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 4098B5597
 for <dev@dpdk.org>; Thu, 16 Feb 2017 11:07:59 +0100 (CET)
In-Reply-To: <2590637.Rj3BpoAWc4@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/16/2017 8:53 AM, Thomas Monjalon wrote:
> 2017-02-15 17:30, Ferruh Yigit:
>> On 2/15/2017 4:58 PM, Thomas Monjalon wrote:
>>> 2017-02-15 15:26, Ferruh Yigit:
>>>> +.PHONY: test-buid
>>>> +test-build:
>>>> +	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig
>>>> +	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test
>>>
>>> Why not rely on default rule below?
>>>
>>> # all other build targets
>>> %:
>>>     $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig
>>>     $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@
>>
>>
>> Because generic rule is using "rte.sdkbuild.mk $@" rule,
>> for unit-test, $@ is test-build, but sdkbuild rule is "test"
>>
>> This can be solved with adding following to sdkbuild.mk:
>>
>> --- a/mk/rte.sdkbuild.mk
>> +++ b/mk/rte.sdkbuild.mk
>> @@ -72,6 +72,9 @@ clean: $(CLEANDIRS)
>>         $(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean
>>         @echo Clean complete
>>
>> +.PHONY: test-build
>> +test-build: test
>> +
>>  .SECONDEXPANSION:
>>  .PHONY: $(ROOTDIRS-y) test
>>  $(ROOTDIRS-y) tes
>>
>>
>> I can update if you think this is better?
> 
> Yes it seems better. Or you can just rename test into test-build
> in rte.sdkbuild.mk.

Can't update to "test-build" in rte.sdkbuild.mk, it needs to be folder
name. I will send new version with above update.

Thanks,
ferruh