From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 2/2] igb_uio: fix interrupt enablement
	after FLR in VM
Date: Mon, 16 Oct 2017 16:52:19 -0700
Message-ID: <e0a2c461-98e4-af2b-df5f-24c90cc1f31d@intel.com>
References: <1507581083-33667-2-git-send-email-jingjing.wu@intel.com>
 <1507586960-35508-1-git-send-email-jingjing.wu@intel.com>
 <9BB6961774997848B5B42BEC655768F810E92434@SHSMSX103.ccr.corp.intel.com>
 <20171013081205.GA20678@localhost.localdomain>
 <8d9e803d-8fbe-c0e2-81d2-62c30a1738a9@intel.com>
 <CAO--2fH0qo0jiuGc9tRX=x7dXLFuOhf0AhEAffsoTCBxCMif5A@mail.gmail.com>
 <D60A83C1.16B739%Harish.Patil@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "Thotton, Shijith" <Shijith.Thotton@cavium.com>,
 "Wu, Jingjing" <jingjing.wu@intel.com>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Patil, Harish" <Harish.Patil@cavium.com>,
 Gregory Etelson <gregory@weka.io>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <D60A83C1.16B739%Harish.Patil@cavium.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/16/2017 3:49 PM, Patil, Harish wrote:
> From: Gregory Etelson <gregory@weka.io <mailto:gregory@weka.io>>
> Date: Saturday, October 14, 2017 at 8:10 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>>
> Cc: "Thotton, Shijith" <Shijith.Thotton@cavium.com
> <mailto:Shijith.Thotton@cavium.com>>, "Wu, Jingjing"
> <jingjing.wu@intel.com <mailto:jingjing.wu@intel.com>>, Harish Patil
> <Harish.Patil@cavium.com <mailto:Harish.Patil@cavium.com>>, "Tan,
> Jianfeng" <jianfeng.tan@intel.com <mailto:jianfeng.tan@intel.com>>,
> "Xing, Beilei" <beilei.xing@intel.com <mailto:beilei.xing@intel.com>>,
> "dev@dpdk.org <mailto:dev@dpdk.org>" <dev@dpdk.org
> <mailto:dev@dpdk.org>>, "stable@dpdk.org <mailto:stable@dpdk.org>"
> <stable@dpdk.org <mailto:stable@dpdk.org>>
> Subject: Re: [PATCH v2 2/2] igb_uio: fix interrupt enablement after FLR
> in VM
> 
>     I'll start to build setup environment this week.
>     Regards,
>     Gregory
> 
>     On Sat, Oct 14, 2017 at 12:11 AM, Ferruh Yigit
>     <ferruh.yigit@intel.com <mailto:ferruh.yigit@intel.com>> wrote:
> 
>         On 10/13/2017 9:12 AM, Shijith Thotton wrote:
>         <...>
> 
>         > Hi Jingjing,
>         >
>         > This patch perfectly meets requirements as both resets are retained
>         > (open and release). Tested it with LiquidIO NIC and it works fine.
>         > I can see MSI-X re-enabled on each run with new patch.
>         >
>         > Gregory, Harish,
>         > Please verify the patch on your setup if possible.
> 
>         Hi Gregory, Harish,
> 
>         Did you able to test this patch?
> 
>         Thanks,
>         ferruh
> 
>         >
>         > Thanks,
>         > Shijith
>         >
> 
> 
> 
> Hi all,
> Its not working for qede VF device.
> So request to back out all igb_uio changes related to the patch:
> igb_uio: issue FLR during open and release of device file 

Hi Harish,

Thanks for testing. We tried.

For this release, agreed to revert back to original state, I will send a
patch soon.


But for further investigation in next release, can you please share more
details? What is not working exactly, what is your setup, any
kernel/DPDK log to share?

Thanks,
ferruh

> 
> Thanks,
> Harish
>