From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v1] doc/eth: update document for functional limitation Date: Fri, 25 May 2018 10:12:00 +0100 Message-ID: References: <1527069959-37765-1-git-send-email-vipin.varghese@intel.com> <1748708.EYc6N8xVZC@xps> <039ED4275CED7440929022BC67E70611531B8235@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611531B8653@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Kovacevic, Marko" , "Jain, Deepak K" To: "Zhang, Qi Z" , Thomas Monjalon , "Varghese, Vipin" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 92BD914E8 for ; Fri, 25 May 2018 11:12:03 +0200 (CEST) In-Reply-To: <039ED4275CED7440929022BC67E70611531B8653@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/25/2018 10:08 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Friday, May 25, 2018 4:35 PM >> To: Zhang, Qi Z ; Thomas Monjalon >> ; Varghese, Vipin >> Cc: dev@dpdk.org; Kovacevic, Marko ; Jain, >> Deepak K >> Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional >> limitation >> >> On 5/25/2018 1:44 AM, Zhang, Qi Z wrote: >>> >>> >>>> -----Original Message----- >>>> From: Thomas Monjalon [mailto:thomas@monjalon.net] >>>> Sent: Friday, May 25, 2018 1:06 AM >>>> To: Varghese, Vipin >>>> Cc: dev@dpdk.org; Zhang, Qi Z ; Kovacevic, >>>> Marko ; Jain, Deepak K >>>> ; Yigit, Ferruh >>>> Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for >>>> functional limitation >>>> >>>> 23/05/2018 12:05, Vipin Varghese: >>>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>>> @@ -1479,6 +1479,9 @@ int rte_eth_dev_attach(const char *devargs, >>>> uint16_t *port_id); >>>>> * This function must be called when the device is in the >>>>> * closed state. >>>>> * >>>>> + * Note: >>>>> + * - Currently supported for primary process only. >>>> >>>> I think it should be possible to attach a device in secondary process. >>>> If it is a recent limitation, it should be in "known issues" of the release >> notes. >>> >>> For PCI device, we can only attached a device that is already resource >>> mapped in primary process (for example, a device not in secondary process' >> white list but in primary process's) And we should not detached a device in >> secondary process, that will mess primary process and cause it can't be >> attached again. >>> >>> For vdev, I think we still can attached/detach a new device which does not >> exist in primary process. >> >> For vdev it was possible to attach a new device in secondary, but it seems >> primary process checks has been added to virtual PMDs probe() function by [1] >> which seems breaking this capability, can you please check it? > > Yes, attach vdev "net_af_packet,iface=eth0" on secondary process will create a private device. Yep, Qi kindly explained me that it is still possible create vdevs using rte_eth_dev_attach() on secondary process. So this patch is not exactly correct. >> >> >> [1] >> Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") >> >>> >>>> >>>> >>> >