From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/af_packet: initialize link interrupt callback queue Date: Wed, 21 Dec 2016 15:26:21 +0000 Message-ID: References: <1481997835-23288-1-git-send-email-3chas3@gmail.com> <40da3bb6-9d84-9703-36f7-a0eb21fc48dc@intel.com> <1482267451.1677.5.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "John W. Linville" To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 200D010C9D for ; Wed, 21 Dec 2016 16:26:24 +0100 (CET) In-Reply-To: <1482267451.1677.5.camel@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/20/2016 8:57 PM, Chas Williams wrote: > On Tue, 2016-12-20 at 14:20 +0000, Ferruh Yigit wrote: >> On 12/17/2016 6:03 PM, Chas Williams wrote: >>> This patch initializes the eth_dev->link_intr_cbs queue which is >>> used when af_packet is passed into rte_eth_ev_callback_register(). >> >> Why do you want to register callback to af_packet PMD, it won't be >> calling them? > > Because I have a some other code that basically treats all the PMD's > the same way. Do I really need to write an exception for that code > that says "if this is driver such and such don't call this API routine?" No, you shouldn't. Thanks for the clarification. > >>> >>> Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") >>> >>> Signed-off-by: Chas Williams <3chas3@gmail.com> >> >> Please cc the maintainers... > > OK > >> >> CC: John W. Linville >> >>> --- >>> drivers/net/af_packet/rte_eth_af_packet.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c >>> index a1e13ff..ea5070a 100644 >>> --- a/drivers/net/af_packet/rte_eth_af_packet.c >>> +++ b/drivers/net/af_packet/rte_eth_af_packet.c >>> @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name, >>> (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name; >>> (*eth_dev)->data->kdrv = RTE_KDRV_NONE; >>> (*eth_dev)->data->numa_node = numa_node; >>> + TAILQ_INIT(&((*eth_dev)->link_intr_cbs)); >>> >>> return 0; >>> >>> >> >>