From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2] vfio: noiommu check error handling Date: Tue, 16 Jan 2018 10:07:51 +0000 Message-ID: References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com> <5559040.Nhk1psZjz2@xps> <45d1aa7c-2ceb-b6df-8e16-83ff1316cba1@intel.com> <2075027.JcYejM7RvO@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Jonas Pfefferle , Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7673B2BB5 for ; Tue, 16 Jan 2018 11:07:55 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 15-Jan-18 12:22 PM, Jonas Pfefferle wrote: > >  On Sat, 13 Jan 2018 23:49:30 +0100 >  Thomas Monjalon wrote: >> 13/01/2018 13:15, Burakov, Anatoly: >>> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: >>> > 07/11/2017 10:50, Jonas Pfefferle1: >>> >>> Is there something urgent for 17.11? >>> >>> Or can it be refined in 18.02? >>> >> >>> >> Nothing urgent. We can refine this for 18.02. >>> >> >>> >>> Anatoly, any thought? >>> > > Anatoly, Jonas, how do you want to proceed with this patch? >>> > >>> I don't see anything to be refined here, it's a simple bug fix - code >>> assumes noiommu mode support is always available, when it might not >>> be the case on older kernels. >> >> As a bug fix, the title must start with "fix" and a tag "Fixes:" >> must be added to help with backport. >> At the same time, the explanation of the bug must be added in >> the commit log please. >> >> Thanks > > It's not really a bug fix since it does not change the semantic of the > function but just adds nicer error handling. Well, as far as i can tell, it *does* change semantics - previously, if noiommu mode file was not found, we returned -1, now we return 0. -- Thanks, Anatoly