From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 3/6] eal: remove log level from internal config Date: Tue, 18 Apr 2017 16:00:45 +0100 Message-ID: References: <20170418142225.6308-1-olivier.matz@6wind.com> <20170418142225.6308-3-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: jianfeng.tan@intel.com, thomas@monjalon.net To: Olivier Matz , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3C30EF94 for ; Tue, 18 Apr 2017 17:00:47 +0200 (CEST) In-Reply-To: <20170418142225.6308-3-olivier.matz@6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/18/2017 3:22 PM, Olivier Matz wrote: > This field is only used in the initialization phase. Remove it since the > global log level can also be retrieved using a public API: > rte_log_get_global_level(). > > Signed-off-by: Olivier Matz <...> > diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c > index dd4d30ca7..7d13cc026 100644 > --- a/lib/librte_eal/common/eal_common_log.c > +++ b/lib/librte_eal/common/eal_common_log.c > @@ -244,6 +244,12 @@ RTE_INIT(rte_log_init); > static void > rte_log_init(void) > { > +#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG Why ">=" (I aware previous one is also like this :), setting global config option to RTE_LOG_DEBUG cause a INFO level log... > + rte_log_set_global_level(RTE_LOG_INFO); > +#else > + rte_log_set_global_level(RTE_LOG_LEVEL); > +#endif