From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 4/4] net/i40e: refine consistent tunnel filter
Date: Wed, 8 Mar 2017 15:50:33 +0000
Message-ID: <e3720374-17c0-c3e7-cd6d-4be55ccb480f@intel.com>
References: <1488533497-27682-1-git-send-email-beilei.xing@intel.com>
 <1488533497-27682-5-git-send-email-beilei.xing@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: helin.zhang@intel.com, dev@dpdk.org
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 77086BD28
 for <dev@dpdk.org>; Wed,  8 Mar 2017 16:50:36 +0100 (CET)
In-Reply-To: <1488533497-27682-5-git-send-email-beilei.xing@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/3/2017 9:31 AM, Beilei Xing wrote:
> Add i40e_tunnel_type enumeration type to refine consistent
> tunnel filter, it will be esay to add new tunnel type for

s/esay/easy

> i40e.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

>  /**
> + * Tunnel type.
> + */
> +enum i40e_tunnel_type {
> +	I40E_TUNNEL_TYPE_NONE = 0,
> +	I40E_TUNNEL_TYPE_VXLAN,
> +	I40E_TUNNEL_TYPE_GENEVE,
> +	I40E_TUNNEL_TYPE_TEREDO,
> +	I40E_TUNNEL_TYPE_NVGRE,
> +	I40E_TUNNEL_TYPE_IP_IN_GRE,
> +	I40E_L2_TUNNEL_TYPE_E_TAG,
> +	I40E_TUNNEL_TYPE_MAX,
> +};

Same question here, there is already "rte_eth_tunnel_type", why driver
is duplicating the structure?

<...>