From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] mk: add debug target
Date: Thu, 1 Feb 2018 17:04:39 +0000
Message-ID: <e4160725-1bb3-914a-f888-37498d6c0b34@intel.com>
References: <20171216001350.90436-1-ferruh.yigit@intel.com>
 <9672510.c4JnJd36Tx@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AE8AC3257
 for <dev@dpdk.org>; Thu,  1 Feb 2018 18:04:43 +0100 (CET)
In-Reply-To: <9672510.c4JnJd36Tx@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/30/2018 11:40 PM, Thomas Monjalon wrote:
> 16/12/2017 01:13, Ferruh Yigit:
>> Add "debug" target to build library with debug symbols and optimization
>> disabled.
>>
>> This is shortcut for exiting method to compile with
>> EXTRA_CFLAGS="-O0 -g3"
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> +	debug            build library with debug symbols
> [...]
>> +.PHONY: debug
>> +debug:
>> +	$(Q)$(MAKE) EXTRA_CFLAGS="-O0 -g3"
> 
> This target will override any EXTRA_CFLAGS,
> so we cannot build in debug mode with more extra cflags this way.

How about EXTRA_CFLAGS+="-O0 -g3"
which is not override EXTRA_CFLAGS but merge them, can be ok?

> 
> I think the cons are higher than the pros.
>