From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v6 7/8] eal: enable PCI bus
Date: Mon, 16 Jan 2017 19:58:59 +0000
Message-ID: <e55e3020-2750-1219-b9a3-f608a4b43dbe@intel.com>
References: <1484581107-2025-1-git-send-email-shreyansh.jain@nxp.com>
 <1484581107-2025-8-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, thomas.monjalon@6wind.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, david.marchand@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 99C9F108F
 for <dev@dpdk.org>; Mon, 16 Jan 2017 20:59:02 +0100 (CET)
In-Reply-To: <1484581107-2025-8-git-send-email-shreyansh.jain@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/16/2017 3:38 PM, Shreyansh Jain wrote:
> Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage.
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---

<...>

> -/* Init the PCI EAL subsystem */
> -int
> -rte_eal_pci_init(void)
> -{
> -	/* for debug purposes, PCI can be disabled */
> -	if (internal_config.no_pci)
> -		return 0;

Are we losing this feature? Should this check moved to rte_eal_pci_scan() ?

<...>