From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C258C79FB9 for ; Thu, 10 Sep 2026 12:54:01 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DAE7427DC; Thu, 10 Sep 2026 14:53:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id 0FCE3427C6 for ; Thu, 10 Sep 2026 14:53:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789044807; x=1820580807; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=5Z0HWp3zCRXv80lscfm3J71jdNHcRSp4oJOdHohxdTQ=; b=RDYqUC34NiexkAjjWjabuCaZfNowmytBP+/31NaMNMPra104/oVHdQVJ GM6cAE+61qzno8F+yfNwIMarCip2IU8gE1R+T5L4OlKqmudx3Mc+zqP8J OR4/q5NFPiUNEnTQ4DXcQeFlFgautyGBxHycUsis3IFAByfZsVmUGmi6j aPon/nV2nvwILzWUbkcvqWWW5gG2vJDaXplntjSWafZ//wU+2IXtrdZA9 dnAMt+k9plfTOXkyshIncbM9FinMENwg2iyuyzg9ncbmotai9E9WaJrfE KFw8bEjJHn6n1kOyOgFMkvrdYGtI4YwLVDtRwSNrc5dVQtYV8jL6iGV8f w==; X-CSE-ConnectionGUID: E36IuEO3RFudKTxp9SD1ew== X-CSE-MsgGUID: gypX7CpqQTahP27IE4CPfQ== X-IronPort-AV: E=McAfee;i="6800,10657,11900"; a="89334019" X-IronPort-AV: E=Sophos;i="6.27,95,1787036400"; d="scan'208";a="89334019" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2026 05:53:26 -0700 X-CSE-ConnectionGUID: JRSUXoMlS1mEZwroNyA04A== X-CSE-MsgGUID: 2wxanObTREKmd4xCoqLPnA== X-ExtLoop1: 1 Received: from silpixa00401119.ir.intel.com ([10.20.224.206]) by fmviesa003.fm.intel.com with ESMTP; 10 Sep 2026 05:53:26 -0700 From: Anatoly Burakov To: dev@dpdk.org, Bruce Richardson , Dmitry Kozlyuk Subject: [PATCH v17 05/26] vfio: decouple EAL from VFIO internals Date: Thu, 10 Sep 2026 13:52:49 +0100 Message-ID: X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, the multiprocess cleanup for VFIO is called via an internal-only API, and this is the only thing `eal_vfio.h` is used for in EAL. In order to make `eal_vfio.h` truly VFIO-internal, export a cleanup function from `rte_vfio` API instead, and call that. This allows us to remove all EAL references to `eal_vfio.h` in non-VFIO related files. Signed-off-by: Anatoly Burakov --- lib/eal/freebsd/eal.c | 6 ++++++ lib/eal/include/rte_vfio.h | 9 +++++++++ lib/eal/linux/eal.c | 3 +-- lib/eal/linux/eal_vfio.c | 7 +++++++ lib/eal/windows/eal.c | 6 ++++++ 5 files changed, 29 insertions(+), 2 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 0fe54a9dd7..991ca45064 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -845,6 +845,12 @@ int rte_vfio_enable(__rte_unused const char *modname) return -1; } +RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_cleanup) +void +rte_vfio_cleanup(void) +{ +} + RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_is_enabled) int rte_vfio_is_enabled(__rte_unused const char *modname) { diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h index 0ddeb08f94..e76181c83c 100644 --- a/lib/eal/include/rte_vfio.h +++ b/lib/eal/include/rte_vfio.h @@ -109,6 +109,15 @@ int rte_vfio_release_device(const char *sysfs_base, const char *dev_addr, int fd __rte_internal int rte_vfio_enable(const char *modname); +/** + * @internal + * Cleanup VFIO resources. + * + * This function is only relevant to Linux. + */ +__rte_internal +void rte_vfio_cleanup(void); + /** * @internal * Check whether a VFIO-related kmod is enabled. diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index fc2e9b8c0e..5577bab24a 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -54,7 +54,6 @@ #include "eal_memcfg.h" #include "eal_trace.h" #include "eal_options.h" -#include "eal_vfio.h" #include "hotplug_mp.h" #include "log_internal.h" @@ -986,7 +985,7 @@ rte_eal_cleanup(void) rte_service_finalize(); eal_bus_cleanup(); - vfio_mp_sync_cleanup(); + rte_vfio_cleanup(); rte_mp_channel_cleanup(); rte_eal_alarm_cleanup(); rte_trace_save(); diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c index 33fa04feaf..6c77076bc3 100644 --- a/lib/eal/linux/eal_vfio.c +++ b/lib/eal/linux/eal_vfio.c @@ -2217,3 +2217,10 @@ rte_vfio_container_dma_unmap(int container_fd, uint64_t vaddr, uint64_t iova, return container_dma_unmap(vfio_cfg, vaddr, iova, len); } + +RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_cleanup) +void +rte_vfio_cleanup(void) +{ + vfio_mp_sync_cleanup(); +} diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index de7a89a829..b8771d4d85 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -152,6 +152,12 @@ rte_eal_cleanup(void) return 0; } +RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_cleanup) +void +rte_vfio_cleanup(void) +{ +} + /* Launch threads, called at application init(). */ RTE_EXPORT_SYMBOL(rte_eal_init) int -- 2.52.0