From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/4] net/cxgbe: fix macros related to logs
 for Windows
Date: Wed, 19 Dec 2018 13:45:39 +0000
Message-ID: <e5fc5853-e7ad-b990-e540-e35c26023f90@intel.com>
References: <1544713333-32239-1-git-send-email-rahul.lakkireddy@chelsio.com>
 <1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com>
 <7aca347c-b551-f092-ba3b-e31e83eeed26@intel.com>
 <20181219123925.GA11932@chelsio.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Satish Rangarajan <satishr@chelsio.com>,
 Indranil Choudhury <indranil@chelsio.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 24C8E1B5B8
 for <dev@dpdk.org>; Wed, 19 Dec 2018 14:45:42 +0100 (CET)
In-Reply-To: <20181219123925.GA11932@chelsio.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/19/2018 12:39 PM, Rahul Lakkireddy wrote:
> On Tuesday, December 12/18/18, 2018 at 23:55:26 +0530, Ferruh Yigit wrote:
>> On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
>>> Replace "args..." with "fmt, ..." and directly use __VA_ARGS__.
>>
>> What do you mean exactly by "for Windows"? Which compiler? Is there a specific C
>> standard version you target? What is the issue with existing macros?
>>
>> Since we don't have a Windows support in DPDK, yet, it is not clear what you are
>> targeting.
>>
> 
> These patches are a pre-requisite to enable compilation for CXGBE PMD for
> Windows OS. It currently uses Intel C++ compiler [1]. Our plan is to
> integrate these compilation fixes to dpdk-next-net and then ask for a
> pull request to pull these to dpdk-draft-windows tree [2].

I think that is OK as long as we don't break the existing platforms, which is
the case already. I am asking from documentation / keeping record point of view.

Would you mind sending a new version of the patchset, with more detailed commit
logs, target compiler and its version, target Windows OS and dependencies if
any, the log of the error the patch fixes (like below ones) ?

Thanks,
ferruh

> 
> These existing macros result in following errors in Windows build:
> 
> # cxgbe_compat.h(28): error : expected a ")"
>     #define dev_printf(level, fmt, args...) \
>                                        ^
> 
> # cxgbe_compat.h(31): error : expected a ")"
>     #define dev_err(x, args...) dev_printf(ERR, args)
> 
> [...]
> 
> [1] https://software.intel.com/en-us/parallel-studio-xe
> [2] http://git.dpdk.org/draft/dpdk-draft-windows/
> 
> Thanks,
> Rahul
>