From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v1] doc/eth: update document for functional
 limitation
Date: Fri, 25 May 2018 09:34:38 +0100
Message-ID: <e61b4ac9-dfed-cae5-264c-28a151657605@intel.com>
References: <1527069959-37765-1-git-send-email-vipin.varghese@intel.com>
 <1748708.EYc6N8xVZC@xps>
 <039ED4275CED7440929022BC67E70611531B8235@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Kovacevic, Marko" <marko.kovacevic@intel.com>,
 "Jain, Deepak K" <deepak.k.jain@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 "Varghese, Vipin" <vipin.varghese@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id E02A4239
 for <dev@dpdk.org>; Fri, 25 May 2018 10:34:41 +0200 (CEST)
In-Reply-To: <039ED4275CED7440929022BC67E70611531B8235@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/25/2018 1:44 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Friday, May 25, 2018 1:06 AM
>> To: Varghese, Vipin <vipin.varghese@intel.com>
>> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Kovacevic, Marko
>> <marko.kovacevic@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
>> Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional
>> limitation
>>
>> 23/05/2018 12:05, Vipin Varghese:
>>> --- a/lib/librte_ethdev/rte_ethdev.h
>>> +++ b/lib/librte_ethdev/rte_ethdev.h
>>> @@ -1479,6 +1479,9 @@ int rte_eth_dev_attach(const char *devargs,
>> uint16_t *port_id);
>>>   * This function must be called when the device is in the
>>>   * closed state.
>>>   *
>>> + * Note:
>>> + * - Currently supported for primary process only.
>>
>> I think it should be possible to attach a device in secondary process.
>> If it is a recent limitation, it should be in "known issues" of the release notes.
> 
> For PCI device, we can only attached a device that is already resource mapped in primary process (for example, a device not in secondary process' white list but in primary process's)
> And we should not detached a device in secondary process, that will mess primary process and cause it can't be attached again.
> 
> For vdev, I think we still can attached/detach a new device which does not exist in primary process.

For vdev it was possible to attach a new device in secondary, but it seems
primary process checks has been added to virtual PMDs probe() function by [1]
which seems breaking this capability, can you please check it?


[1]
Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process")

> 
>>
>>
>