From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 11/41] bus/dpaa: add QMan driver core
	routines
Date: Tue, 19 Sep 2017 19:48:04 +0530
Message-ID: <e77fbef4-4deb-07de-d4d5-049658e29d80@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-12-shreyansh.jain@nxp.com>
 <ba4b670c-ae65-14cd-ac2a-3a029e2716f3@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0062.outbound.protection.outlook.com [104.47.33.62])
 by dpdk.org (Postfix) with ESMTP id 833511B1A4
 for <dev@dpdk.org>; Tue, 19 Sep 2017 16:07:11 +0200 (CEST)
In-Reply-To: <ba4b670c-ae65-14cd-ac2a-3a029e2716f3@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
>> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
>> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
>> +#ifdef RTE_LIBRTE_DPAA_CHECKING
> 
> This is not defined anywhere, it looks this will come from config file
> in further patches, config file update can be moved to this patch.

Its more of a debugging macro and it was introduced in later patches.
Not that I see any reason why it can't be introduced here. I will fix this.

> 
>> +	eqcr->busy = 0;
>> +	eqcr->pmode = pmode;
>> +#endif
> 
> <...>
> 
>