From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB02EC388F9 for ; Wed, 11 Nov 2020 13:07:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 59B6A206CA for ; Wed, 11 Nov 2020 13:07:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B6A206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B7BF137D; Wed, 11 Nov 2020 14:07:27 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CFC04F90 for ; Wed, 11 Nov 2020 14:07:25 +0100 (CET) IronPort-SDR: 40rzmgofR/oBPyLR851z9YBpBpSO+UqBD6CQOyZuoI+GjS6trWD8gKjtv5VxH0MDYQ66N4Pp5+ cFFSlmrCVHVQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="234307847" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="234307847" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 05:07:20 -0800 IronPort-SDR: jDivQZ6/2wX/nvb/DBlaoJmtaXLNdMxWU0o9AbmN+z3Kf6gCf8c/zzEpw4dV27ahvlHfpWZhRO OiK0fTTOCkPA== X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="473844064" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.123]) ([10.213.241.123]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 05:07:18 -0800 To: Ziyang Xuan , Guoyang Zhou , Xiaoyun Wang References: <2027a001-c422-6464-ccff-1d3d90039ecd@huawei.com> <19384408-c7b8-8140-2f92-a4fcc071715f@huawei.com> Cc: dev@dpdk.org, Qingqing Li , Hushiyuan From: Ferruh Yigit Message-ID: Date: Wed, 11 Nov 2020 13:07:14 +0000 MIME-Version: 1.0 In-Reply-To: <19384408-c7b8-8140-2f92-a4fcc071715f@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH]net/hinic: fix coredump when secondary process using the hinic port. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 2:48 PM, Qingqing Li wrote: > the reason is that during the stage of secondary process port initialization, > it lacks the initialization of "eth_dev->dev_ops". > > Signed-off-by: Qingqing Li Hi Ziyang, Guoyang, Xiaoyun, The patch is around for a long time [1], can you please review the patch? Review has been requested multiple times now, not sure why there is no response. As 'hinic' driver maintainers, expectation is not just send patches to your driver, also review patches in the community, *at least* ones against your driver. Thanks, ferruh [1] https://patches.dpdk.org/patch/75318/ https://patches.dpdk.org/patch/75319/ [ There are a few more versions in between ] https://patches.dpdk.org/patch/83174/ https://patches.dpdk.org/patch/83421/ [This one]