From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [PATCH v3 2/4] devargs: simplify parameters of
 removal function
Date: Mon, 1 Oct 2018 14:25:50 +0300
Message-ID: <e79c873f-19fb-9d07-964b-f1921e2f8e9e@solarflare.com>
References: <20180907222727.20521-1-thomas@monjalon.net>
 <20180928162144.1972-1-thomas@monjalon.net>
 <20180928162144.1972-3-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <gaetan.rivet@6wind.com>, <ophirmu@mellanox.com>, <qi.z.zhang@intel.com>,
 <ferruh.yigit@intel.com>, <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 93839695D
 for <dev@dpdk.org>; Mon,  1 Oct 2018 13:26:41 +0200 (CEST)
In-Reply-To: <20180928162144.1972-3-thomas@monjalon.net>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/28/18 7:21 PM, Thomas Monjalon wrote:
> The function rte_devargs_remove(), which is intended to be internal,
> can take a devargs structure as argument.
> The matching is still using string comparison of bus name and
> device name.
> It is simpler and may allow a different devargs matching in future.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

What about release notes? It is API change, yes, experimental, but still.