From mboxrd@z Thu Jan  1 00:00:00 1970
From: gowrishankar muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Subject: Re: [PATCH] bus/fslmc: use PRIu64 instead of llX in
 format specifier
Date: Fri, 13 Apr 2018 14:13:28 +0530
Message-ID: <e7d0dcb0-8eb4-3081-0092-52bff60e8f1b@linux.vnet.ibm.com>
References: <5438d3242ebb9d995d0a52a63feba80efd783e6f.1523595487.git.gowrishankar.m@linux.vnet.ibm.com>
 <4074558.oWdUdNoPZr@xps> <893c8705-858c-336d-c600-c4a23e8fea5b@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
 [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 4488A1BBC5
 for <dev@dpdk.org>; Fri, 13 Apr 2018 10:43:39 +0200 (CEST)
Received: from pps.filterd (m0098396.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id
 w3D8h6MW068942 for <dev@dpdk.org>; Fri, 13 Apr 2018 04:43:38 -0400
Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])
 by mx0a-001b2d01.pphosted.com with ESMTP id 2harpd9rws-1
 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT)
 for <dev@dpdk.org>; Fri, 13 Apr 2018 04:43:37 -0400
Received: from localhost
 by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
 Violators will be prosecuted
 for <dev@dpdk.org> from <gowrishankar.m@linux.vnet.ibm.com>;
 Fri, 13 Apr 2018 09:43:33 +0100
In-Reply-To: <893c8705-858c-336d-c600-c4a23e8fea5b@nxp.com>
Content-Language: en-GB
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Friday 13 April 2018 02:26 PM, Shreyansh Jain wrote:
> On Friday 13 April 2018 01:11 PM, Thomas Monjalon wrote:
>> 13/04/2018 07:04, Gowrishankar:
>>> -    DPAA2_BUS_DEBUG("--> Map address: %llX, size: 0x%llX",
>>> +    DPAA2_BUS_DEBUG("--> Map address: %"PRIu64", size: 0x%"PRIu64"",
>>
>> You cannot replace hexadecimal by decimal.
>> You need to use PRIx64.
>>
>>
>
> Now that Thomas has pointed out, I think the log message can be 
> improved. Len as hex is not helpful and is out of sync with other 
> messages in this file.
>
> While on this, I think it should be corrected.
> I will fix this.
>
> @gowrishankar, I will post a patch in reply to your patch - can you 
> please help me with ppc64le check? I will take care of Hemant's comment.

Yup, I check for it. Thanks Shreyansh.

>
> -
> Shreyansh
>