From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH 2/3] net/virtio_user: fix wrong sequence of
	messages
Date: Fri, 9 Sep 2016 14:24:20 +0800
Message-ID: <e7d1dd81-b1c0-3c9c-f371-c8c01924c2ef@intel.com>
References: <1470397003-5782-1-git-send-email-jianfeng.tan@intel.com>
 <1470397003-5782-3-git-send-email-jianfeng.tan@intel.com>
 <20160906064246.GQ30752@yliu-dev.sh.intel.com>
 <bac1d3e5-7643-3eb5-2515-d4a8f745c94d@intel.com>
 <20160906082011.GA23158@yliu-dev.sh.intel.com>
 <53e1d78c-e3b0-e16c-992d-e45ed1b31a4f@intel.com>
 <20160908121818.GO23158@yliu-dev.sh.intel.com>
 <11291eac-cbbe-7080-3d35-bdacb5341d89@intel.com>
 <20160909041949.GP23158@yliu-dev.sh.intel.com>
 <1537a739-9805-cd51-cf0a-f32d608a97e0@intel.com>
 <20160909060348.GQ23158@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, zhihong.wang@intel.com, lining18@jd.com
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 8D3972C0A
 for <dev@dpdk.org>; Fri,  9 Sep 2016 08:24:23 +0200 (CEST)
In-Reply-To: <20160909060348.GQ23158@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 9/9/2016 2:03 PM, Yuanhan Liu wrote:
>> GET_PROTOCOL_FEATURES
>> is not supported yet. I see those features in PROTOCOL_FEATURES is for live
>> migration (right?).
> Not exactly. PROTOCOL_FEATURES was firstly introduced while MQ was
> enabled. Thus it's no wonder MQ is the first protocol feature vhost
> user supports:
>
>      [yliu@yliu-dev ~/dpdk]$ gg PROTOCOL_F_ lib/librte_vhost/
>      lib/librte_vhost/vhost_user.h:46:#define VHOST_USER_PROTOCOL_F_MQ 0
>      lib/librte_vhost/vhost_user.h:47:#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 1
>      lib/librte_vhost/vhost_user.h:48:#define VHOST_USER_PROTOCOL_F_RARP 2
>
> 	--yliu

OK, I got it. The maximum of queue pair number is now a parameter of 
virtio_user, but we need to depend on PROTOCOL_FEATURES (further, 
VHOST_USER_GET_QUEUE_NUM) to maximum queue pair number that vhost can 
support.

Just wonder why not QEMU depends on (1ULL << VIRTIO_NET_F_MQ) inside 
features to do that?

Thanks,
Jianfeng

>
>> Assuming that, anyone using container/process now
>> enables live migration so far? I don't think so.
>>
>> Thanks,
>> Jianfeng
>>
>>
>>> 	--yliu