From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v3 8/9] autotest: update autotest test case
	list
Date: Mon, 16 Jul 2018 16:16:03 +0100
Message-ID: <e8b5eb1e-7cff-28d7-dc97-591f3c97d23b@intel.com>
References: <cover.1528404133.git.anatoly.burakov@intel.com>
 <1531750337-4708-9-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: jananeex.m.parthasarathy@intel.com, stable@dpdk.org
To: Reshma Pattan <reshma.pattan@intel.com>, thomas@monjalon.net, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1531750337-4708-9-git-send-email-reshma.pattan@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 16-Jul-18 3:12 PM, Reshma Pattan wrote:
> Autotest is enhanced with additional test cases
> being added to autotest_data.py
> 
> Removed non existing PCI autotest.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> ---

<snip>

> +    },
> +    {
> +        "Name":    "Flow classify autotest",
> +        "Command": "flow_classify_autotest",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +        {
> +        "Name":    "Set rxtx mode",
> +        "Command": "set_rxtx_mode",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "Set rxtx anchor",
> +        "Command": "set_rxtx_anchor",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "Set rxtx sc",
> +        "Command": "set_rxtx_sc",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },

The above three tests don't look like autotests to me. I have no idea 
what they are for, but either they need a special function, or they need 
to be taken out.

> +    {
> +        "Name":    "Event eth rx adapter autotest",
> +        "Command": "event_eth_rx_adapter_autotest",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "Rawdev autotest",
> +        "Command": "rawdev_autotest",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },

<snip>

> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "Barrier autotest",
> +        "Command": "barrier_autotest",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "User delay",
> +        "Command": "user_delay_us",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },

This doesn't look like autotests to me. I have no idea what it is for, 
but either it needs a special function, or it needs to be taken out.

> +    {
> +        "Name":    "Bitmap test",
> +        "Command": "bitmap_test",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "Hash scaling autotest",
> +        "Command": "hash_scaling_autotest",
> +        "Func":    default_autotest,
> +        "Report":  None,
> +    },
> +    {
> +        "Name":    "Hash multiwriter autotest",
> +        "Command": "hash_multiwriter_autotest",


-- 
Thanks,
Anatoly