From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling
Date: Mon, 26 Mar 2018 12:38:22 +0100
Message-ID: <e962380a-181e-3d5e-d5c9-65f1c269e63f@intel.com>
References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com>
 <1522009169-13860-1-git-send-email-ophirmu@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>,
 Shahaf shuler <shahafs@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>, dev@dpdk.org,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id A652A325F
 for <dev@dpdk.org>; Mon, 26 Mar 2018 13:38:25 +0200 (CEST)
In-Reply-To: <1522009169-13860-1-git-send-email-ophirmu@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/25/2018 9:19 PM, Ophir Munk wrote:
> Previous to this commit mlx4 CRC stripping was executed by default and
> there was no verbs API to disable it.

Are you aware of the discussion about CRC [1]? Is this patch compatible with plans?

[1]
https://dpdk.org/dev/patchwork/patch/36415/

> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> v1: initial version
> v2: following internal reviews
> v3: following dpdk.org mailing list reviews

<...>