From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 0/2] ethdev: add support for raw flow type
 for flow director
Date: Wed, 4 Oct 2017 18:44:19 +0100
Message-ID: <e96e47fc-0ae3-84b0-930f-c0351c8b2094@intel.com>
References: <1503588634-85735-1-git-send-email-kirill.rybalchenko@intel.com>
 <1505896926-70362-1-git-send-email-kirill.rybalchenko@intel.com>
 <c277ca5f-d734-b5ac-5ee7-96ed98563a12@intel.com> <13345393.msxc2hlS7D@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, andrey.chilikin@intel.com, beilei.xing@intel.com,
 jingjing.wu@intel.com
To: Thomas Monjalon <thomas@monjalon.net>,
 Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 2EE601B6C3
 for <dev@dpdk.org>; Wed,  4 Oct 2017 19:44:21 +0200 (CEST)
In-Reply-To: <13345393.msxc2hlS7D@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/4/2017 5:57 PM, Thomas Monjalon wrote:
> 03/10/2017 21:02, Ferruh Yigit:
>> On 9/20/2017 9:42 AM, Kirill Rybalchenko wrote:
>>> For complex packets use raw flow type with pre-constructed packet buffer
>>> instead of creating a packet internally in PMD.
> 
> Sorry for not catching this series before.
> 
> As it has been said several times on this mailing list,
> the flow director API is deprecated.
> I think everybody here knows that it is going to be replaced
> by rte_flow.
> 
> That's why it does not make sense to extend flow director.
> We are not going to update PMDs to support a new type
> of legacy flow director.
> Please focus your efforts on rte_flow.

As far as I can see this is not to to extend flow director. But driver
uses this struct and adding a new feature into driver requires update in
this struct.

I guess idea was for new filter functionalities PMD should use rte_flow,
that is the new shiny method we have, I see the point here. But I don't
see the point of making these structs under use completely immutable.

> 
> 
>>> Kirill Rybalchenko (2):
>>>   ethdev: add support for raw flow type for flow director
>>>   net/i40e: add support for raw flow type for flow director
>>
>> Series Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>