From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM. Date: Wed, 9 Jan 2019 16:53:52 +0000 Message-ID: References: <20181226163712.31596-1-i.maximets@samsung.com> <20190109145015.3010-1-i.maximets@samsung.com> <20190109095445-mutt-send-email-mst@kernel.org> <823f9d3e-1018-5923-d6fb-330beae65b88@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Maxime Coquelin , Xiao Wang , Tiwei Bie , Zhihong Wang , jfreimann@redhat.com, Jason Wang , xiaolong.ye@intel.com, alejandro.lucero@netronome.com To: Ilya Maximets , "Michael S. Tsirkin" Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C6CE91B4BE for ; Wed, 9 Jan 2019 17:53:58 +0100 (CET) In-Reply-To: <823f9d3e-1018-5923-d6fb-330beae65b88@samsung.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/9/2019 3:24 PM, Ilya Maximets wrote: > On 09.01.2019 17:55, Michael S. Tsirkin wrote: >> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >>> Version 3: >>> * Added 2 patches with fixes for current virtio driver. >>> Not directly connected with the new feature. >> >> New version shouldn't be reply-to old one really :). > > It's kind of a common practice and a recommended thing for the > dpdk mail-list. At least it was. > I'm not doing that on other lists. =) Yes this is something recommended to do. It helps a lot to be able to see all versions and comments in same email thread. > >> But the patches are good I think. >> >> Acked-by: Michael S. Tsirkin > > Thanks. > >> >> >> >>> Version 2: >>> * rebased on current master (packed rings). >>> >>> RFC --> Version 1: >>> * Dropped vendor-specific hack to determine if we need real barriers. >>> * Added VIRTIO_F_ORDER_PLATFORM feature definition and checking. >>> >>> Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER >>> to VIRTIO_F_ORDER_PLATFORM is not merged yet: >>> https://www.mail-archive.com/virtio-dev@lists.oasis-open.org/msg04114.html >>> >>> Ilya Maximets (3): >>> net/virtio: add missing barrier before reading the flags >>> net/virtio: update memory ordering comment for vq notify >>> net/virtio: add platform memory ordering feature support >>> >>> drivers/net/virtio/virtio_ethdev.c | 2 ++ >>> drivers/net/virtio/virtio_ethdev.h | 3 +- >>> drivers/net/virtio/virtio_pci.h | 7 ++++ >>> drivers/net/virtio/virtio_rxtx.c | 16 ++++----- >>> drivers/net/virtio/virtqueue.h | 56 +++++++++++++++++++++++------- >>> 5 files changed, 63 insertions(+), 21 deletions(-) >>> >>> -- >>> 2.17.1 >> >>