From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FABC3A59E for ; Wed, 21 Aug 2019 13:20:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 0F76B22CF7 for ; Wed, 21 Aug 2019 13:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F76B22CF7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43FD31BEFF; Wed, 21 Aug 2019 15:20:32 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9E6C71BEFE; Wed, 21 Aug 2019 15:20:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2019 06:20:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,412,1559545200"; d="scan'208";a="178501341" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.108]) ([10.237.220.108]) by fmsmga008.fm.intel.com with ESMTP; 21 Aug 2019 06:20:28 -0700 To: Chaitanya Babu Talluri , dev@dpdk.org Cc: reshma.pattan@intel.com, jananeex.m.parthasarathy@intel.com, stable@dpdk.org References: <1566392575-7965-1-git-send-email-tallurix.chaitanya.babu@intel.com> <1566392575-7965-2-git-send-email-tallurix.chaitanya.babu@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 21 Aug 2019 14:20:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1566392575-7965-2-git-send-email-tallurix.chaitanya.babu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] lib/eal: fix vfio unmap that fails unexpectedly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21-Aug-19 2:02 PM, Chaitanya Babu Talluri wrote: > Unmap of multiple pages fails after a sequence of partial map/unmaps. > The scenario is that multiple maps are created in user_mem_maps, > after multiple map/unmap/remap sequences. > > For an example, > Steps: > 1. Map 3 pages together > 2. Un-map page1 > 3. Re-map page 1 > 4. Un-map page 2 > 5. Re-map page 2 > 6. Un-map page 3 > 7. Re-map page 3 > 8. Un-map all pages I don't think this description is correct in relation to what is being fixed here. The code attempts to prevent overlaps, but there are no overlaps in the above example - none of the above operations would trigger the added code. -- Thanks, Anatoly