From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost/crypto: fix coverity issues Date: Wed, 27 Mar 2019 11:18:01 +0100 Message-ID: References: <20190325143731.6488-1-roy.fan.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org To: Fan Zhang , dev@dpdk.org Return-path: In-Reply-To: <20190325143731.6488-1-roy.fan.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/19 3:37 PM, Fan Zhang wrote: > Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode") > > Coverity Issue: 277214 > Coverity Issue: 277220 > Coverity Issue: 277233 > Coverity Issue: 277236 > > Cc: stable@dpdk.org > > Signed-off-by: Fan Zhang > --- > lib/librte_vhost/vhost_crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c > index 9b4b850e8..0edf12d52 100644 > --- a/lib/librte_vhost/vhost_crypto.c > +++ b/lib/librte_vhost/vhost_crypto.c > @@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op, > > if (unlikely(copy_data(digest_addr, vc_req, &digest_desc, > chain->para.hash_result_len, > - nb_descs, vq_size)) < 0) { > + nb_descs, vq_size) < 0)) { > ret = VIRTIO_CRYPTO_BADMSG; > goto error_exit; > } > @@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid, > op->sym->m_src->data_off = 0; > > if (unlikely(vhost_crypto_process_one_req(vcrypto, vq, > - op, head, desc_idx)) < 0) > + op, head, desc_idx) < 0)) > break; > } > > Good catch from Coverity! Reviewed-by: Maxime Coquelin Thanks, Maxime