From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD
 callbacks for eth Tx adapter
Date: Tue, 21 Aug 2018 14:22:15 +0530
Message-ID: <ea3fb374-fe77-5a59-c443-67c13abff831@intel.com>
References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com>
 <1534479652-80182-2-git-send-email-nikhil.rao@intel.com>
 <20180819104534.GB11085@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: olivier.matz@6wind.com, dev@dpdk.org, nikhil.rao@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id DF2C92C5
 for <dev@dpdk.org>; Tue, 21 Aug 2018 10:52:22 +0200 (CEST)
In-Reply-To: <20180819104534.GB11085@jerin>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/19/2018 4:15 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Fri, 17 Aug 2018 09:50:50 +0530
>> From: Nikhil Rao <nikhil.rao@intel.com>
>> To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com
>> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>
>> Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx
>>   adapter
>> X-Mailer: git-send-email 1.8.3.1
>>
>>
>> The caps API allows the application to query if the transmit
>> stage is implemented in the eventdev PMD or uses the common
>> rte_service function. The PMD callbacks support the
>> eventdev PMD implementation of the adapter.
>>
>> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
>> ---
>> +
>>   static inline int
>>   rte_event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues)
>>   {
>> @@ -1275,6 +1300,15 @@ int rte_event_dev_selftest(uint8_t dev_id)
>>          return RTE_EVENT_MAX_DEVS;
>>   }
>>
>> @@ -1295,6 +1329,9 @@ struct rte_eventdev *
>>
>>          eventdev = &rte_eventdevs[dev_id];
>>
>> +       if (eventdev->txa_enqueue == NULL)
> 
> Is this check required, it will be always NULL. Right? if so,
> Can't we write eventdev->txa_enqueue directly?
> 
>> +               eventdev->txa_enqueue = rte_event_tx_adapter_enqueue;
>> +
> 

The thought was that if the PMD supports txa_enqueue then it wouldn't be 
NULL.

Thanks for the review,
Nikhil