From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v6 01/15] vhost: add virtio packed virtqueue defines Date: Wed, 4 Jul 2018 18:03:07 +0200 Message-ID: References: <20180702081629.29258-1-maxime.coquelin@redhat.com> <20180702081629.29258-2-maxime.coquelin@redhat.com> <20180704053733.GA28826@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org, mst@redhat.com, jasowang@redhat.com, wexu@redhat.com To: Tiwei Bie Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 450711BE18 for ; Wed, 4 Jul 2018 18:03:15 +0200 (CEST) In-Reply-To: <20180704053733.GA28826@debian> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/04/2018 07:37 AM, Tiwei Bie wrote: > On Mon, Jul 02, 2018 at 10:16:15AM +0200, Maxime Coquelin wrote: >> From: Jens Freimann >> >> Signed-off-by: Jens Freimann >> --- >> lib/librte_vhost/vhost.h | 3 +++ >> lib/librte_vhost/virtio-packed.h | 22 ++++++++++++++++++++++ >> 2 files changed, 25 insertions(+) >> create mode 100644 lib/librte_vhost/virtio-packed.h >> >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h >> index 3f8fa3a78..cecd5c1ee 100644 >> --- a/lib/librte_vhost/vhost.h >> +++ b/lib/librte_vhost/vhost.h >> @@ -191,6 +191,9 @@ struct vhost_msg { >> #ifndef VIRTIO_F_VERSION_1 >> #define VIRTIO_F_VERSION_1 32 >> #endif >> +#ifndef VIRTIO_F_RING_PACKED >> + #define VIRTIO_F_RING_PACKED 34 >> +#endif >> >> /* Features supported by this builtin vhost-user net driver. */ >> #define VIRTIO_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ >> diff --git a/lib/librte_vhost/virtio-packed.h b/lib/librte_vhost/virtio-packed.h >> new file mode 100644 >> index 000000000..744b3991b >> --- /dev/null >> +++ b/lib/librte_vhost/virtio-packed.h >> @@ -0,0 +1,22 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) Red Hat Inc. >> + */ >> + >> +#ifndef __VIRTIO_PACKED_H >> +#define __VIRTIO_PACKED_H >> + >> +#define VRING_DESC_F_NEXT 1 >> +#define VRING_DESC_F_WRITE 2 >> +#define VRING_DESC_F_INDIRECT 4 >> + >> +#define VRING_DESC_F_AVAIL (1ULL << 7) >> +#define VRING_DESC_F_USED (1ULL << 15) > > Please use space or tab consistently. Right. Thanks, Maxime >> + >> +struct vring_desc_packed { >> + uint64_t addr; >> + uint32_t len; >> + uint16_t index; >> + uint16_t flags; >> +}; >> + >> +#endif /* __VIRTIO_PACKED_H */ >> -- >> 2.14.4 >>