From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wang Subject: Re: [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping Date: Mon, 13 Oct 2014 18:42:18 +0000 Message-ID: References: <1413181389-14887-1-git-send-email-yongwang@vmware.com> <1413181389-14887-2-git-send-email-yongwang@vmware.com>, <20141013113146.202b5eb3@uryu.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Stephen Hemminger Return-path: In-Reply-To: <20141013113146.202b5eb3-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Are you referring to the patch as a whole or your comment is about the rese= t of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I = get your comments here. This patch simply fixes a bug on the rx vlan strip= ping path (where valid vlan_tci stripped is overwritten unconditionally lat= er on the rx path in the original vmxnet3 pmd driver). All the other pmd dr= ivers are doing the same thing in terms of translating descriptor status to= rte_mbuf flags for vlan stripping.=0A= ________________________________________=0A= From: Stephen Hemminger =0A= Sent: Monday, October 13, 2014 2:31 AM=0A= To: Yong Wang=0A= Cc: dev-VfR2kkLFssw@public.gmane.org=0A= Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping=0A= =0A= On Sun, 12 Oct 2014 23:23:05 -0700=0A= Yong Wang wrote:=0A= =0A= > Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.=0A= >=0A= > Signed-off-by: Yong Wang =0A= =0A= Since vlan_tci is initialized to zero by rte_pktmbuf layer,=0A= the driver shouldn't be messing with it.=0A= =0A=