From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v8 07/10] eal: replace rte_panic instances in
 hugepage_info
Date: Wed, 25 Apr 2018 14:50:13 +0100
Message-ID: <ebbf4ff8-76c4-6cde-d4b9-da334d7943f0@intel.com>
References: <1524608213-2080-1-git-send-email-arnon@qwilt.com>
 <1524663944-30376-1-git-send-email-arnon@qwilt.com>
 <1524663944-30376-8-git-send-email-arnon@qwilt.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>, thomas@monjalon.net,
 wenzhuo.lu@intel.com, declan.doherty@intel.com,
 jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
 ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id B3B557CBA
 for <dev@dpdk.org>; Wed, 25 Apr 2018 15:50:17 +0200 (CEST)
In-Reply-To: <1524663944-30376-8-git-send-email-arnon@qwilt.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 25-Apr-18 2:45 PM, Arnon Warshavsky wrote:
> replace panic calls with log and return value.
> 
> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
> ---

I think i've already acked this. You should keep acks etc. between 
versions (unless you're making significant enough changes that you think 
would invalidate a prior ack). Having acks makes it easier to track what 
still needs to be reviewed and what is good to go, and it makes it 
easier to see if the entire patchset is ready for apply.

-- 
Thanks,
Anatoly