From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/bonding: fix bond 8023ad mode enable
 using wrong index
Date: Fri, 15 Dec 2017 12:48:35 -0800
Message-ID: <ec70dd45-9414-0804-3de7-ac67c6214672@intel.com>
References: <40280F65B1B0B44E8089ED31C01616EBA357ADA1@dggeml509-mbx.china.huawei.com>
 <884f321f-6aac-2bf2-9388-09a5b75f6c50@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "Zhang, Jerry" <jerry.zhang@intel.com>, Wanghanlin <hanlin.wang@huawei.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
 "Lilijun (Jerry)" <jerry.lilijun@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "tomaszx.kulasek@intel.com" <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id B7B3C4B4B
 for <dev@dpdk.org>; Fri, 15 Dec 2017 21:48:38 +0100 (CET)
In-Reply-To: <884f321f-6aac-2bf2-9388-09a5b75f6c50@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/12/2017 7:58 AM, Doherty, Declan wrote:
> On 20/11/2017 7:15 AM, Lilijun (Jerry) wrote:
>> Hi all,
>>
>> In the function bond_mode_8023ad_enable(), the var i is to used to as the second parameter to pass the slave dev's dpdk port id to the function bond_mode_8023ad_activate_slave().
>> I think this variable is only a index for array internals->active_slaves. So its need to be fixed and change i to internals->active_slaves[i].

    net/bonding: fix activated slave in 8023ad mode

    In the function bond_mode_8023ad_enable(), the var i is used as slave
    port id to the function bond_mode_8023ad_activate_slave().

    This variable is only a index for array internals->active_slaves.
    So its need to be fixed and change i to internals->active_slaves[i].

    Fixes: 46fb43683679 ("bond: add mode 4")
    Cc: stable@dpdk.org

>>
>>
>> [Patch] net/bonding: fix bond 8023ad mode enable using wrong index.
>> Signed-off-by: Lilijun <jerry.lilijun@huawei.com>

Tested-by: Kyle Larose <klarose@sandvine.com>

> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-net/master, thanks.