From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Green Subject: Re: [PATCH v4 11/18] net/sfc: correct strncpy length Date: Sat, 12 May 2018 09:21:20 +0800 Message-ID: References: <152600304856.53146.9681482138854493833.stgit@localhost.localdomain> <152600317109.53146.6555330710274289069.stgit@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "stable@dpdk.org" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Return-path: In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/11/2018 06:51 PM, De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green >> Sent: Friday, May 11, 2018 2:46 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length >> >> Signed-off-by: Andy Green >> --- >> drivers/net/sfc/sfc_ethdev.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index >> e42d55350..ef5e9ecb2 100644 >> --- a/drivers/net/sfc/sfc_ethdev.c >> +++ b/drivers/net/sfc/sfc_ethdev.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "efx.h" >> >> @@ -741,9 +742,8 @@ sfc_xstats_get_names_by_id(struct rte_eth_dev *dev, >> if ((ids == NULL) || (ids[nb_written] == nb_supported)) { >> char *name = xstats_names[nb_written++].name; >> >> - strncpy(name, efx_mac_stat_name(sa->nic, i), >> + strlcpy(name, efx_mac_stat_name(sa->nic, i), >> sizeof(xstats_names[0].name)); > > Shouldn't this be "sizeof(name)"? Although probably it is the same. name is just a pointer, so sizeof that is 4 or 8. -Andy > Missing fixes line and CC stable. > > Fixes: 73280c1e4ff2 ("net/sfc: support xstats retrieval by ID") > Cc: stable@dpdk.org >