From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 16/17] vhost: rename header file Date: Tue, 14 Mar 2017 13:59:49 +0100 Message-ID: References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com> <1488534682-3494-17-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Harris James R , Liu Changpeng To: Yuanhan Liu , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F14A92C74 for ; Tue, 14 Mar 2017 13:59:53 +0100 (CET) In-Reply-To: <1488534682-3494-17-git-send-email-yuanhan.liu@linux.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/03/2017 10:51 AM, Yuanhan Liu wrote: > Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio > net specific. > > Signed-off-by: Yuanhan Liu > --- > doc/guides/rel_notes/deprecation.rst | 9 -- > drivers/net/vhost/rte_eth_vhost.c | 2 +- > drivers/net/vhost/rte_eth_vhost.h | 2 +- > examples/tep_termination/main.c | 2 +- > examples/tep_termination/vxlan_setup.c | 2 +- > examples/vhost/main.c | 2 +- > lib/librte_vhost/Makefile | 2 +- > lib/librte_vhost/rte_vhost.h | 259 +++++++++++++++++++++++++++++++++ > lib/librte_vhost/rte_virtio_net.h | 259 --------------------------------- Did you perform the rename using git mv? > lib/librte_vhost/vhost.c | 2 +- > lib/librte_vhost/vhost.h | 2 +- > lib/librte_vhost/vhost_user.h | 2 +- > lib/librte_vhost/virtio_net.c | 2 +- > 13 files changed, 269 insertions(+), 278 deletions(-) > create mode 100644 lib/librte_vhost/rte_vhost.h > delete mode 100644 lib/librte_vhost/rte_virtio_net.h Other than that, the change looks good to me: Reviewed-by: Maxime Coquelin Thanks, Maxime