From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [v2, 3/6] eventdev: add crypto adapter implementation
Date: Wed, 25 Apr 2018 19:44:00 +0530
Message-ID: <edab56cb-8bbf-066c-bc0e-5b57e45489ff@nxp.com>
References: <1524573807-168522-1-git-send-email-abhinandan.gujjar@intel.com>
 <1524573807-168522-4-git-send-email-abhinandan.gujjar@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: narender.vangati@intel.com, nikhil.rao@intel.com, gage.eads@intel.com
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
 jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com,
 dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0076.outbound.protection.outlook.com [104.47.0.76])
 by dpdk.org (Postfix) with ESMTP id CDC0A7CBA
 for <dev@dpdk.org>; Wed, 25 Apr 2018 16:14:18 +0200 (CEST)
In-Reply-To: <1524573807-168522-4-git-send-email-abhinandan.gujjar@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/24/2018 6:13 PM, Abhinandan Gujjar wrote:
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> ---

[snip..]
> +int __rte_experimental
> +rte_event_crypto_adapter_start(uint8_t id)
> +{
> +	struct rte_event_crypto_adapter *adapter;
> +
> +	RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
> +	adapter = eca_id_to_adapter(id);
> +	if (adapter == NULL)
> +		return -EINVAL;
This check is redundant here. you are null checking it again in 
eca_adapter_ctrl
> +
> +	return eca_adapter_ctrl(id, 1);
> +}
> +
> +int __rte_experimental
> +rte_event_crypto_adapter_stop(uint8_t id)
> +{
> +	return eca_adapter_ctrl(id, 0);
> +}
> +

[snip..]
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 3ee28f7..774f7c5 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -72,6 +72,18 @@ DPDK_18.02 {
>  	global:
>
>  	rte_event_dev_selftest;
> +	rte_event_crypto_adapter_create_ext;
> +	rte_event_crypto_adapter_create;
> +	rte_event_crypto_adapter_free;
> +	rte_event_crypto_adapter_queue_pair_add;
> +	rte_event_crypto_adapter_queue_pair_del;
> +	rte_event_crypto_adapter_start;
> +	rte_event_crypto_adapter_stop;
> +	rte_event_crypto_adapter_stats_get;
> +	rte_event_crypto_adapter_stats_reset;
> +	rte_event_crypto_adapter_service_id_get;
> +	rte_event_crypto_adapter_event_port_get;
> +
I believe these shall go in EXPERIMENTAL along with timer.
>  } DPDK_17.11;
>
>  DPDK_18.05 {
>