From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH] examples/l3fwd-power: fix prog exit on ini
	pwr lib
Date: Wed, 7 Nov 2018 14:21:21 +0000
Message-ID: <edc2ea7f-e14a-1610-6f5e-2b113c6297ec@intel.com>
References: <1541599750-18432-1-git-send-email-motih@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "radu.nicolau@intel.com" <radu.nicolau@intel.com>
To: Mordechay Haimovsky <motih@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 922C034F3
 for <dev@dpdk.org>; Wed,  7 Nov 2018 15:21:24 +0100 (CET)
In-Reply-To: <1541599750-18432-1-git-send-email-motih@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Mordechay,

On 7/11/2018 2:09 PM, Mordechay Haimovsky wrote:
> This patch replaces the rte_exit routine with error printing when
> init_power_library() fails and by that restores the previous behavior
> of the program (which was to issue an error message and continue
> working if init_power_library fails). This allows the user to still
> experience the Rx interrupts feature of the DPDK demonstrated in
> this program.
>
> Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options")
> Cc: radu.nicolau@intel.com
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
>   examples/l3fwd-power/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index 0b3f8fe..9c7b315 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -1957,7 +1957,7 @@ static int check_ptype(uint16_t portid)
>   		rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
>   
>   	if (init_power_library())
> -		rte_exit(EXIT_FAILURE, "init_power_library failed\n");
> +		RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n");
>   
>   	if (update_lcore_params() < 0)
>   		rte_exit(EXIT_FAILURE, "update_lcore_params failed\n");

Acked-by: David Hunt <david.hunt@intel.com>