From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters Date: Thu, 15 Mar 2018 09:02:36 +0000 Message-ID: References: <20180307120851.5822-1-remy.horton@intel.com> <20180307120851.5822-2-remy.horton@intel.com> <023fbd6c-7cac-6c8b-9a40-7a62e5d47bb7@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Thomas Monjalon To: Shreyansh Jain , Ferruh Yigit , "dev@dpdk.org" Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3829B7CFC for ; Thu, 15 Mar 2018 10:02:40 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/03/2018 15:10, Shreyansh Jain wrote: [..] >> What do you think renaming structure and variable name, >> "preferred_dev_config" perhaps? > > I missed this naming while reading this patch. In the deprecation > notice, 'preferred_size' was the name we came up with precisely on > this issue of structure having queue length and burst size. > > What about using that same name? Because of namespace issues it will need at least the rte_ prefix. Otherwise seems good to me as I cannot think of anything else that is relatively short.