From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rao, Nikhil" Subject: Re: [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev Date: Thu, 14 Sep 2017 08:34:20 +0530 Message-ID: References: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com> <1505219369-2493-3-git-send-email-nikhil.rao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "gage.eads@intel.com" , "dev@dpdk.org" , "thomas@monjalon.net" , "harry.van.haaren@intel.com" , Hemant Agrawal , "narender.vangati@intel.com" , "erik.g.carrillo@intel.com" , "abhinandan.gujjar@intel.com" To: Nipun Gupta , "jerin.jacob@caviumnetworks.com" , "bruce.richardson@intel.com" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id BE93C1B1B4 for ; Thu, 14 Sep 2017 05:04:27 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/2017 7:06 PM, Nipun Gupta wrote: > > >> -----Original Message----- >> From: Nikhil Rao [mailto:nikhil.rao@intel.com] >> --- >> lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++++++ >> drivers/event/sw/sw_evdev.c | 13 +++++++++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h >> b/lib/librte_eventdev/rte_eventdev_pmd.h >> index 4cc9671..3cbc063 100644 >> --- a/lib/librte_eventdev/rte_eventdev_pmd.h >> +++ b/lib/librte_eventdev/rte_eventdev_pmd.h >> @@ -83,6 +83,12 @@ extern "C" { >> } \ >> } while (0) >> >> +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \ >> + RTE_EVENT_ETH_RX_ADAPTER_CAP_FLOW_ID >> +/**< Ethernet Rx adapter cap to return If the packet transfers from >> + * the ethdev to eventdev use a SW service function >> + */ > > Hi Nikhil, > > Maybe it makes more sense to have RTE_EVENT_ETH_RX_ADAPTER_SW_CAP #define in 'sw_evdev.h' file? > The usage of this #define is not intended to be restricted to sw_evdev.c. Eventdev PMDs may need to use the SW implementation of ethdev to eventdev packet transfer for some eth ports (e.g., veth) while they may support a HW transfer mechanism for SoC eth ports, in that case the eventdev PMD would need access to this define. Hope that answers your question. Thanks, Nikhil