From: Raslan Darawsheh <rasland@nvidia.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>, dev@dpdk.org
Cc: matan@nvidia.com, suanmingm@nvidia.com, dsosnowski@nvidia.com
Subject: Re: [PATCH v2] net/mlx5: cleanup unused olx parameter in Tx free routines
Date: Tue, 24 Mar 2026 17:28:25 +0200 [thread overview]
Message-ID: <eed95506-15d9-44b8-ad61-a321336751fa@nvidia.com> (raw)
In-Reply-To: <20260323124110.425154-1-viacheslavo@nvidia.com>
Hi,
On 23/03/2026 2:41 PM, Viacheslav Ovsiienko wrote:
> The olx parameter is intended to be known in compile time and
> widely used for static optimizations while generating the tx_burst
> rotuines code from the template.
>
> However, in the mlx5_tx_free_mbuf routine we have the olx parameter
> provided in runtime only, for all possible execution paths. And the
> only intended optimization (that actually does not happen) is to check
> whether multi-buf packets are supported. As fast free offload is not
> supported for multi-buf packets, we can simplify the code and get rid of
> the unused olx parameter in the entire call chain.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2026-03-24 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 10:13 [PATCH] net/mlx5: cleanup unused olx parameter in Tx free routines Viacheslav Ovsiienko
2026-03-23 12:41 ` [PATCH v2] " Viacheslav Ovsiienko
2026-03-24 15:28 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed95506-15d9-44b8-ad61-a321336751fa@nvidia.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox