From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: fix close callfd on get vring base Date: Fri, 2 Mar 2018 12:05:29 +0100 Message-ID: References: <20180209171049.7132-1-tomaszx.kulasek@intel.com> <75099b6d-b9ac-7edb-fd31-2bc4410390b4@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, huawei.xie@intel.com, stable@dpdk.org, Dariusz Stojaczyk To: Tomasz Kulasek , yliu@fridaylinux.org Return-path: In-Reply-To: <75099b6d-b9ac-7edb-fd31-2bc4410390b4@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tomasz, On 02/20/2018 10:09 AM, Maxime Coquelin wrote: > > > On 02/09/2018 06:10 PM, Tomasz Kulasek wrote: >> This prevents from destroying & recreating user device in "incomplete" >> vring state. virtio_is_ready() was returning true for devices with >> vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL >> hasn't arrived yet) >> >> Fixes: 8f972312b8f4 ("vhost: support vhost-user") >> Cc:huawei.xie@intel.com >> Cc:stable@dpdk.org >> >> Signed-off-by: Dariusz Stojaczyk >> Signed-off-by: Tomasz Kulasek >> --- >>   lib/librte_vhost/vhost_user.c | 5 +++++ >>   1 file changed, 5 insertions(+) > > Reviewed-by: Maxime Coquelin > > and applied to dpdk-next-virtio/master. I reworded the title: vhost: cleanup device properly at stop time Let me know if this is fine to you Thanks, Maxime > Thanks, > Maxime