From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] igb_uio: remove device reset in open
Date: Mon, 23 Oct 2017 09:36:38 -0700
Message-ID: <ef41920f-4d5e-df48-b249-d09c47280382@intel.com>
References: <efabcaad-b0e9-e360-22b5-953b0bc20032@intel.com>
 <20171020165511.47899-1-ferruh.yigit@intel.com>
 <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com>
 <20171023122807.GA17153@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Jingjing Wu <jingjing.wu@intel.com>, Gregory Etelson <gregory@weka.io>,
 Harish Patil <harish.patil@cavium.com>, Thomas Monjalon
 <thomas@monjalon.net>, dev@dpdk.org, stable@dpdk.org,
 Jianfeng Tan <jianfeng.tan@intel.com>, George Prekas
 <george.prekas@epfl.ch>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20171023122807.GA17153@localhost.localdomain>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/23/2017 5:28 AM, Shijith Thotton wrote:
> On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote:
>> On 10/20/2017 9:55 AM, Ferruh Yigit wrote:
>>> Remove device reset during application start, the reset for application
>>> exit still there.
>>>
>>> Reset in open removed because of following comments:
>>> 1- Device reset not completed when VF driver loaded, which cause VF PMD
>>>    initialization error.
>>>    Adding delay can solve the issue but will increase driver load time.
>>>
>>> 2- Reset will be issues all devices unconditionally, not very efficient
>>>    way.
>>>
>>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Hi Jingjing, Shijith, Gregory, Harish,
>>
>> Can you please test this on top of current master (which has already Jingjin's
>> fix) ?
> 
> Hi Ferruh,
> 
> Tested for LiquidIO cards and it works.

Thanks Shijith,

Is following commit needs to be reverted after pci_reset removed from open():

Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver")

Thanks,
ferruh

> 
> Thanks,
> Shijith
>