From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v7 9/9] eal: enable hotplugging of devices on
 bus
Date: Tue, 17 Jan 2017 10:47:55 +0000
Message-ID: <efeef9a6-05b7-6637-aec0-fa3dcbd2d7bb@intel.com>
References: <1484581107-2025-1-git-send-email-shreyansh.jain@nxp.com>
 <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com>
 <1484647774-28984-10-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, thomas.monjalon@6wind.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, david.marchand@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id DD31BDE5
 for <dev@dpdk.org>; Tue, 17 Jan 2017 11:47:57 +0100 (CET)
In-Reply-To: <1484647774-28984-10-git-send-email-shreyansh.jain@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/17/2017 10:09 AM, Shreyansh Jain wrote:
> Given a bus, attach and detach callbacks allow the implementation to
> handles calls from EAL for attaching or detaching a named device.
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> +/**
> + * Search and detach a PCI device from PCI Bus
> + * Implements rte_bus->detach
> + *
> + * @param device_name
> + *	Name of the device to search and detach
> + *
> + * @return
> + *	0 for successful detaching of device
> + *	>0 if device not found on bus
> + *	<0 in case of error in removal.

These are the return values expected by rte_eal_dev_detach(), but
rte_eal_pci_detach() is not following these right now, which is causing
failure on detaching virtual devices.

Fix is not complex, it may be an option to fix this as a separate patch
after this patchset applied.

> + */
> +int
> +rte_eal_pci_detach(const char *device_name);
> +
> +/**

<...>