From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Doherty, Declan" Subject: Re: [PATCH 0/3] Break dependency on bus infrastructure* Date: Mon, 23 Oct 2017 10:21:03 +0100 Message-ID: References: <20171020212113.4543-1-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: dev@dpdk.org, pablo.de.lara.guarch@intel.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, roy.fan.zhang@intel.com, fiona.trahe@intel.com, jblunck@infradead.org, jianfeng.tan@intel.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8686A1B3C5 for ; Mon, 23 Oct 2017 11:21:07 +0200 (CEST) In-Reply-To: <20171020212113.4543-1-declan.doherty@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hey folks, to assist in the work of moving the PCI (http://dpdk.org/ml/archives/dev/2017-October/078803.html) and virtual bus (http://dpdk.org/ml/archives/dev/2017-October/077858.html, http://dpdk.org/ml/archives/dev/2017-October/078783.html) out of EAL I've put together this patch set which I think gives a clearer approach to breaking the dependency which the cryptodev library had on the bus infrastructure. It also allows the removal of some replicate boiler plate code in the crypto PMDs. Please have a look and make sure that I haven't introduced any problems to your respective PMDs. Regards Declan On 20/10/2017 10:21 PM, Declan Doherty wrote: > This patch set breaks the dependency of the cryptodev library on both the > virtual and PCI device infrastructure. > > It introduces new bus independent crypto PMD driver assist functions for > parsing initialisation parameters, and creation/destruction of device > instances. > > It deprecates all function calls to the bus dependent functions and > updates all crypto PMDs to use the newly introduced device independent > functions. > > Declan Doherty (3): > cryptodev: add new APIs to assist PMD initialisation > cryptodev: break dependency on virtual device bus > cryptodev: break dependency on rte_pci.h > > doc/guides/rel_notes/deprecation.rst | 6 + > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 55 +++----- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 72 +++++----- > drivers/crypto/armv8/rte_armv8_pmd.c | 41 ++---- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 11 +- > drivers/crypto/dpaa_sec/dpaa_sec.c | 14 +- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 47 +++---- > drivers/crypto/mrvl/rte_mrvl_pmd.c | 56 +++----- > drivers/crypto/null/null_crypto_pmd.c | 72 ++++------ > drivers/crypto/openssl/rte_openssl_pmd.c | 42 ++---- > drivers/crypto/qat/qat_crypto.c | 3 +- > drivers/crypto/qat/rte_qat_cryptodev.c | 55 ++++++-- > drivers/crypto/scheduler/scheduler_pmd.c | 45 ++---- > drivers/crypto/scheduler/scheduler_pmd_ops.c | 3 +- > drivers/crypto/snow3g/rte_snow3g_pmd.c | 41 ++---- > drivers/crypto/zuc/rte_zuc_pmd.c | 41 +++--- > lib/librte_cryptodev/Makefile | 2 - > lib/librte_cryptodev/rte_cryptodev.h | 8 +- > lib/librte_cryptodev/rte_cryptodev_pci.h | 92 ------------- > lib/librte_cryptodev/rte_cryptodev_pmd.c | 184 ++++++++++--------------- > lib/librte_cryptodev/rte_cryptodev_pmd.h | 88 ++++++++++++ > lib/librte_cryptodev/rte_cryptodev_vdev.h | 100 -------------- > lib/librte_cryptodev/rte_cryptodev_version.map | 7 +- > 23 files changed, 405 insertions(+), 680 deletions(-) > delete mode 100644 lib/librte_cryptodev/rte_cryptodev_pci.h > delete mode 100644 lib/librte_cryptodev/rte_cryptodev_vdev.h >