From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/qede: fix Tx tunnel offload notsup mask Date: Tue, 13 Nov 2018 12:01:37 +0000 Message-ID: References: <1542046761-2895-1-git-send-email-rasesh.mody@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "Shaikh, Shahed" , Dept-Eng DPDK Dev , "stable@dpdk.org" To: "Mody, Rasesh" , "dev@dpdk.org" Return-path: In-Reply-To: <1542046761-2895-1-git-send-email-rasesh.mody@cavium.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/12/2018 6:19 PM, Mody, Rasesh wrote: > From: Shahed Shaikh > > Tunneling offloads are represented by multi-bit values. So, feature > wise tunneling offload can only be entirely supported/unsupported > using PKT_TX_TUNNEL_MASK. Its upon PMDs to further isolate which of > the tunneling offload types are supported by respective PMD. > Using subset of bits from PKT_TX_TUNNEL_MASK to indicate supported vs > unsupported offloads can lead to undesired result. > > Use PKT_TX_TUNNEL_MASK in QEDE_TX_OFFLOAD_MASK and use independent > value of supported PKT_TX_TUNNEL_* in .tx_pkt_prepare() to mark > supported tunnel offloads. > > Fixes: 44346c24b790 ("net/qede: fix VXLAN tunnel Tx offload flag setting") > Cc: stable@dpdk.org > > Suggested-by: Ferruh Yigit > Signed-off-by: Shahed Shaikh > Reviewed-by: Rasesh Mody Applied to dpdk-next-net/master, thanks.