From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 00/11] Dynamic logging (just do it)
Date: Tue, 19 Dec 2017 17:51:22 -0800
Message-ID: <f1355dc4-bce7-eba6-7374-5cd9ca31424d@intel.com>
References: <20171219063840.18981-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id CF59E1D7
 for <dev@dpdk.org>; Wed, 20 Dec 2017 02:51:24 +0100 (CET)
In-Reply-To: <20171219063840.18981-1-stephen@networkplumber.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/18/2017 10:38 PM, Stephen Hemminger wrote:
> This patch set implements dynamic logging for 11 drivers.
> All these patches are compile tested only. I don't have
> access to most of this hardware.
> 
> It makes more sense to "just do it" for dynamic logging rather
> than keeping TODO lists in the documentation and expecting the
> vendors to fix their own code. The advantage of common repository
> is that global changes can be done.

Hi Stephen,

Thank you for the update, there a few minor comments in relevant patches, except
from them set lgtm.

Overall do you think keeping todo list is a bad idea?
There are a few more issues like this and I am not sure how to communicate them
with PMD maintainers, any suggestion is welcome.

> 
> Stephen Hemminger (11):
>   avp: implement dynamic logging
>   bnx2x: implement dynamic logging
>   vmxnet3: implement dynamic logging
>   ixgbe: implement dynamic logging
>   e1000: implement dynamic logging
>   virtio: implement dynamic logging
>   nfp: implement dynamic logging
>   fm10k: implement dynamic logging
>   ena: implement dynamic logging
>   qede: implement dynamic logging
>   lio: implement dynamic logging

<...>