From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [RFC] kni: remove ethtool support
Date: Tue, 18 Dec 2018 09:20:59 +0000
Message-ID: <f157ae8b-19f7-8c77-d666-dc1f6ac1d841@intel.com>
References: <20181218012539.52921-1-ferruh.yigit@intel.com>
 <CAF+s_FytboQpL+B7og640i-4F3bv3HjhtQvzDD+2FEz0FWcNaA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 00FC71B60B
 for <dev@dpdk.org>; Tue, 18 Dec 2018 10:21:01 +0100 (CET)
In-Reply-To: <CAF+s_FytboQpL+B7og640i-4F3bv3HjhtQvzDD+2FEz0FWcNaA@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/18/2018 8:20 AM, Igor Ryzhov wrote:
> Hi Ferruh,
> 
> Please, look at my patch http://patches.dpdk.org/patch/48454/ and consider
> rebasing your patch over mine.

Sorry about that, yes I will check it today.

> 
> As we discussed with Stephen, KNI needs to supply ethtool_ops with
> .get_link function, to properly support link status.
> So we should save ethtool_ops and implement .get_link using standard
> ethtool_op_get_link.
> 
> Best regards,
> Igor