From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v4 17/41] doc: add NXP DPAA PMD documentation Date: Thu, 28 Sep 2017 17:19:54 +0530 Message-ID: References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-18-shreyansh.jain@nxp.com> <20a0d11e-b011-9ad9-51b7-9657345c9e9d@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: , To: Ferruh Yigit Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0082.outbound.protection.outlook.com [104.47.41.82]) by dpdk.org (Postfix) with ESMTP id 0AB19FFA for ; Thu, 28 Sep 2017 13:39:05 +0200 (CEST) In-Reply-To: <20a0d11e-b011-9ad9-51b7-9657345c9e9d@nxp.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 19 September 2017 07:55 PM, Shreyansh Jain wrote: > On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:21 PM, Shreyansh Jain wrote: >>> Signed-off-by: Hemant Agrawal >>> Signed-off-by: Shreyansh Jain >> [...] >>> +  This is not a DPAA specific configuration - it is a generic RTE >>> config. >>> +  For optimal performance and hardware utilization, it is expected >>> that DPAA >>> +  Mempool driver is used for mempools. For that, this configuration >>> needs to >>> +  enabled. >>> + >>> +Environment Variables >>> +~~~~~~~~~~~~~~~~~~~~~ >>> + >>> +DPAA drivers uses the following environment variables to configure its >>> +state during application initialization: >>> + >>> +- ``DPAA_NUM_RX_QUEUES`` (default 1) >> >> Why not getting this value as device arg? > > We had this discussion during DPAA2 as well. This time, I was not sure > of how the device argument patches are turning out to be after the > re-shuffle being done by Gaetan. So, I kept this as it is. In the v5, I have continued with the old way. I am still reviewing the devargs patches from Gaetan - once that is done, probably after 1711, I will push another patch for removing this environment variable. In fact, in an internal code change, we have removed need to rely on this. but, that is slightly ahead in future.