From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Wang <jasowang@redhat.com>
Subject: Re: [RFC] testpmd: handle UFO packets
Date: Thu, 1 Mar 2018 16:36:30 +0800
Message-ID: <f1ba1d67-53c8-5d81-6a4e-5e599ca7a438@redhat.com>
References: <1519464907-133452-1-git-send-email-jianfeng.tan@intel.com>
 <098ad68d-20af-7646-7be3-ea260333960b@redhat.com>
 <d10ebed6-46bf-aefa-b7bf-6aeb148abac1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: stephen@networkplumber.org, Bruce Richardson
 <bruce.richardson@intel.com>, Tiwei Bie <tiwei.bie@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 9F157101B
 for <dev@dpdk.org>; Thu,  1 Mar 2018 09:36:39 +0100 (CET)
In-Reply-To: <d10ebed6-46bf-aefa-b7bf-6aeb148abac1@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 2018年02月28日 22:53, Tan, Jianfeng wrote:
> Hi Jason,
>
>
> On 2/28/2018 10:10 PM, Jason Wang wrote:
>>
>>
>> On 2018年02月24日 17:35, Jianfeng Tan wrote:
>>> Mostly likely, we will make UFO as a kind of GSO engine.
>>>
>>> For short term, we can just call APIs in librte_ip_frag to fragment.
>>>
>>> To test:
>>>
>>> 1. start testpmd with two vhost port.
>>>   $ set fwd csum
>>>   $ start
>>>
>>> 2. start vm0 connected to vhost0;
>>>   $ ifconfig xxx 1.1.1.1/24 up
>>>   $ ethtool -K xxx ufo on
>>>
>>> 3. start vm1 connected to vhost1;
>>>   $ ifconfig xxx 1.1.1.2/24 up
>>>   $ ethtool -K xxx ufo on
>>>   $ (Fill a large file named 1.txt)
>>>   $ cat 1.txt | socat - udp-sendto:1.1.1.1:5000
>>
>> Just a reminder, UFO was completely removed upstream.
>>
>
> Thank you for the information.
>
> Saw the deprecation patch at Linux v4.16-rc3, wonder what "version+" 
> counts "merden kernels" in "modern kernels will no longer generate UFO 
> skbs"? 

git describe d9d30adf56777c402c0027c0e6ae21f17cc0a365
v4.12-11055-gd9d30ad

So I think any Linux version beyond 4.12 won't generate any UFO packets.

> And this is mostly for stock VMs with old kernels to help the 
> migration from kernel vswitch to user space vswitch.
>

Yes, testpmd may still see UFO packets for old kernels. Just a reminder 
in case you miss it.

(Btw, we plan to support UDP tunnel offload for virtio-net.)

> Will other OSes generate UFO packets, FreeBSD, Windows? Anyone can 
> provide such information?

I don't know about them.

Thanks.

>
> Thanks,
> Jianfeng
>
>