From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v6 02/21] mem: allow memseg lists to be
 marked as external
Date: Thu, 27 Sep 2018 16:33:39 +0530
Message-ID: <f1cd335b-d95b-7fa7-edd8-7fbab241ce3d@nxp.com>
References: <cover.1538044725.git.anatoly.burakov@intel.com>
 <ed151fe0f8e3644030208942c289c76ed95e4494.1538044725.git.anatoly.burakov@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Neil Horman <nhorman@tuxdriver.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, Matan Azrad <matan@mellanox.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie
 <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, laszlo.madarassy@ericsson.com,
 laszlo.vadkerti@ericsson.com, andras.kovacs@ericsson.com,
 winnie.tian@ericsson.com, daniel.andrasi@ericsson.com,
 janos.kobor@ericsson.com, geza.koblo@ericsson.com,
 srinath.mannam@broadcom.com, scott.branden@broadcom.com,
 ajit.khaparde@broadcom.com, keith.wiles@intel.com, thomas@monjalon.net,
 alejandro.lucero@netronome.com
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr10077.outbound.protection.outlook.com [40.107.1.77])
 by dpdk.org (Postfix) with ESMTP id 05FC41B1EC
 for <dev@dpdk.org>; Thu, 27 Sep 2018 13:04:16 +0200 (CEST)
In-Reply-To: <ed151fe0f8e3644030208942c289c76ed95e4494.1538044725.git.anatoly.burakov@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thursday 27 September 2018 04:10 PM, Anatoly Burakov wrote:
> When we allocate and use DPDK memory, we need to be able to
> differentiate between DPDK hugepage segments and segments that
> were made part of DPDK but are externally allocated. Add such
> a property to memseg lists.
> 
> This breaks the ABI, so bump the EAL library ABI version and
> document the change in release notes. This also breaks a few
> internal assumptions about memory contiguousness, so adjust
> malloc code in a few places.
> 
> All current calls for memseg walk functions were adjusted to
> ignore external segments where it made sense.
> 
> Mempools is a special case, because we may be asked to allocate
> a mempool on a specific socket, and we need to ignore all page
> sizes on other heaps or other sockets. Previously, this
> assumption of knowing all page sizes was not a problem, but it
> will be now, so we have to match socket ID with page size when
> calculating minimum page size for a mempool.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> 

Specifically for bus/fslmc perspective and generically for others:

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>